factotum/yaes
1
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Compare commits

base: factotum:d4bc537cbd3d8f97b126900dd9d27eb60c738e08
Branches Tags
factotum:master
..
compare: factotum:38a286da11f28a11923f935d4b1e9507bd60050f
Branches Tags
factotum:master

3 Commits
d4bc537cbd ... 38a286da11

Author SHA1 Message Date
torque
38a286da11
rotctl: actually quit when receiving the quit message 2024-07-18 19:44:41 -07:00
torque
6bd401d9c8
rotctl: add autopark functionality 
Since gpredict doesn't have a park button or anything, this will just
automatically park the antenna when the gpredict rotator controller
disconnects. This may or may not actually be a good idea. We will see.
 2024-07-18 19:44:41 -07:00
torque
0ccc65fd10
controller: restructure control loop 
This should have been multiple commits, but it isn't. Sue me. This
change has two main goals:

1. Sample feedback at the beginning of the control loop iteration so
   that it is always up-to-date when we are computing the actual drive
   outputs. This means we're doing twice the amount of communication
   with the labjack (previously, setting the output and reading the
   feedback was done with a singe command). However, this makes the
   loop structure much more standard, and it means that we aren't
   constantly operating on feedback that is stale by one loop
   interval.

2. Sample feedback into a (configurable size) buffer. This lets us
   operate on aggregated feedback rather than on a single instantaneous
   data point. Right now, feedback is computed as a moving average,
   which acts as a rudimentary low-pass filter, reducing spurious
   single-loop actions due to feedback spikes or other noise. However,
   the other reason to aggregate some backwards data is that it will
   let us do automatic stall detection in a simple way, although that
   is not currently done.
 2024-07-18 19:43:14 -07:00
2 changed files with 4 additions and 6 deletions
Show Stats Expand all files Collapse all files

2
src/Config.zig
View File

@ -92,7 +92,7 @@ pub fn validate(self: Config, err_writer: anytype) !void {
rotctl: RotControlConfig = .{ rotctl: RotControlConfig = .{
.listen_address = "127.0.0.1", .listen_address = "127.0.0.1",
.listen_port = 4533, .listen_port = 4533,
.autopark = false, .autopark = true,
}, },
labjack: LabjackConfig = .{ labjack: LabjackConfig = .{
.device = .autodetect, .device = .autodetect,

8
src/YaesuController.zig
View File

@ -366,12 +366,10 @@ const Controller = struct {
continue; continue;
}; };
{ self.lock.lock();
self.lock.lock(); defer self.lock.unlock();
defer self.lock.unlock();
self.setPosition(self.feedback_buffer.get()); self.setPosition(self.feedback_buffer.get());
}
switch (self.current_state) { switch (self.current_state) {
.initializing, .idle => { .initializing, .idle => {