factotum/libressl-portable
1
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

remove issetuigid wrappers, now that all getenv calls are gone.

Browse Source 
From deraadt@ upstream:

Remove all getenv() calls, especially those wrapped by issetugid().
getenv()'s wrapped by issetugid() are safe, but issetugid() is ...
difficult to impliment on many operating systems.  By accident, a grand
experiment was run over the last year, where issetugid() returned 1 (the
safe value) on a few operating systems.  Noone noticed & complained that
certain environment variables were not working.......
This commit is contained in:
Brent Cook
2015-04-14 07:55:23 -05:00
parent fe3f7fc636
commit 3096ab0e45
9 changed files with 3 additions and 244 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
crypto/Makefile.am
View File

@@ -97,24 +97,6 @@ endif
endif
if !HAVE_ISSETUGID
if HOST_AIX
libcompat_la_SOURCES += compat/issetugid_aix.c
endif
if HOST_LINUX
libcompat_la_SOURCES += compat/issetugid_linux.c
endif
if HOST_HPUX
libcompat_la_SOURCES += compat/issetugid_hpux.c
endif
if HOST_DARWIN
libcompat_la_SOURCES += compat/issetugid_osx.c
endif
if HOST_WIN
libcompat_la_SOURCES += compat/issetugid_win.c
endif
endif
noinst_HEADERS =
noinst_HEADERS += compat/arc4random.h
noinst_HEADERS += compat/arc4random_aix.h