factotum/NOCLIP
1
Fork 0
Code Issues 10 Projects Releases Activity

parser: work around compiler bug

Browse Source 
At some point, (probably during the llvm 16 upgrade, though I haven't
done the legwork to actually narrow it down), zig developed a crash
around the way inline was used here. Since using `inline` was an air
quotes optimization, we can just chuck the designation for the time
being so that compilation will succeed. This may remove more inlines
than is strictly necessary, but I am bravely willing to make that
sacrifice.

See: ziglang/zig#15668
This commit is contained in:
torque 2023-06-01 22:41:41 -07:00
parent 18379cf86c
commit 49edb642e3
Signed by: torque
SSH Key Fingerprint: SHA256:nCrXefBNo6EbjNSQhv0nXmEg/VuNq3sMF5b8zETw3Tk
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
source/parser.zig
View File

@ -274,7 +274,7 @@ pub fn Parser(comptime command: anytype, comptime callback: anytype) type {
return 0; return 0;
} }
inline fn parse_long_tag( fn parse_long_tag(
self: *@This(), self: *@This(),
name: []const u8, name: []const u8,
arg: []const u8, arg: []const u8,
@ -304,7 +304,7 @@ pub fn Parser(comptime command: anytype, comptime callback: anytype) type {
return ParseError.UnknownLongTagParameter; return ParseError.UnknownLongTagParameter;
} }
inline fn parse_short_tag( fn parse_short_tag(
self: *@This(), self: *@This(),
name: []const u8, name: []const u8,
arg: u8, arg: u8,
@ -334,7 +334,7 @@ pub fn Parser(comptime command: anytype, comptime callback: anytype) type {
return ParseError.UnknownShortTagParameter; return ParseError.UnknownShortTagParameter;
} }
inline fn parse_ordinals( fn parse_ordinals(
self: *@This(), self: *@This(),
arg: []const u8, arg: []const u8,
argit: *ncmeta.SliceIterator([][:0]u8), argit: *ncmeta.SliceIterator([][:0]u8),
@ -360,7 +360,7 @@ pub fn Parser(comptime command: anytype, comptime callback: anytype) type {
return self.subcommands.get(arg) orelse ParseError.ExtraValue; return self.subcommands.get(arg) orelse ParseError.ExtraValue;
} }
inline fn push_intermediate_value( fn push_intermediate_value(
self: *@This(), self: *@This(),
comptime param: anytype, comptime param: anytype,
// @TypeOf(param).G.IntermediateValue() should work but appears to trigger a // @TypeOf(param).G.IntermediateValue() should work but appears to trigger a
@ -381,7 +381,7 @@ pub fn Parser(comptime command: anytype, comptime callback: anytype) type {
} }
} }
inline fn apply_param_values( fn apply_param_values(
self: *@This(), self: *@This(),
comptime param: anytype, comptime param: anytype,
argit: anytype, argit: anytype,
@ -410,7 +410,7 @@ pub fn Parser(comptime command: anytype, comptime callback: anytype) type {
} }
} }
inline fn apply_fused_values( fn apply_fused_values(
self: *@This(), self: *@This(),
comptime param: anytype, comptime param: anytype,
value: []const u8, value: []const u8,